Transplant go to py #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 2324 2376 +52
=========================================
+ Hits 2324 2376 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xuri
requested changes
Apr 20, 2025
main.go
Outdated
| } | ||
| result.CommentsLen = len(comments) | ||
| for _, c := range comments { | ||
| result.Comments = append(result.Comments, Comment{Author: c.Author, AuthorID: c.AuthorID, Cell: c.Cell, Text: c.Text, Width: c.Width, Height: c.Height, ParagraphLen: len(c.Paragraph), Paragraph: c.Paragraph}) |
Owner
There was a problem hiding this comment.
Convert to C data type by GoValueToC function.
xuri
approved these changes
Apr 29, 2025
Owner
xuri
left a comment
xuri
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
xuri
added
the
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Transplant go functions to python
Description
Add
How Has This Been Tested
Pass test_excelize.py unittest
Types of changes
Checklist