Skip to content

fix(cmake): Correct linking of dependencies for interface (header-only) libraries. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix(cmake): Correct linking of dependencies for interface (header-only) libraries. #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions CMake/ystdlib-cpp-helpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,14 @@ function(cpp_library)

check_if_header_only(arg_cpp_lib_PRIVATE_SOURCES _IS_INTERFACE_LIB _)
if(_IS_INTERFACE_LIB)
if(arg_cpp_lib_PRIVATE_LINK_LIBRARIES)
message(
FATAL_ERROR
"`PRIVATE_LINK_LIBRARIES` disabled for header-only library ${_ALIAS_TARGET_NAME}."
)
endif()
add_library(${arg_cpp_lib_NAME} INTERFACE)
target_link_libraries(${arg_cpp_lib_NAME} INTERFACE ${arg_cpp_lib_PUBLIC_LINK_LIBRARIES})
target_include_directories(
${arg_cpp_lib_NAME}
INTERFACE
Expand All @@ -82,6 +89,13 @@ function(cpp_library)
${arg_cpp_lib_PUBLIC_HEADERS}
${arg_cpp_lib_PRIVATE_SOURCES}
)
target_link_libraries(
${arg_cpp_lib_NAME}
PUBLIC
${arg_cpp_lib_PUBLIC_LINK_LIBRARIES}
PRIVATE
${arg_cpp_lib_PRIVATE_LINK_LIBRARIES}
)
target_include_directories(
${arg_cpp_lib_NAME}
PUBLIC
Expand All @@ -90,13 +104,6 @@ function(cpp_library)
target_compile_features(${arg_cpp_lib_NAME} PUBLIC cxx_std_20)
endif()

target_link_libraries(
${arg_cpp_lib_NAME}
PUBLIC
${arg_cpp_lib_PUBLIC_LINK_LIBRARIES}
PRIVATE
${arg_cpp_lib_PRIVATE_LINK_LIBRARIES}
)
add_library(${_ALIAS_TARGET_NAME} ALIAS ${arg_cpp_lib_NAME})

if(YSTDLIB_CPP_ENABLE_TESTS)
Expand Down