Fix single-line comment config changes in VS Code June 2025 release #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10 In the `setSingleLineCommentLanguageDefinitions` method, it uses the `String.includes` method to detect when the `lineComment` string `includes` a semi-colon - ;. The `lineComment` the language config has changed to be either a string or an object. The object has a `comment` and `noIndent` keys. The `includes` method fails due to it being an object and errors out with "lineComment.includes is not a function". To fix: - Added a check to see if the `lineComment` is an object with a `comment` key inside, if it does then use the string value of the `comment` key. Otherwise, it will use the string value of the `lineComment`.
yCodeTech
changed the title
yCodeTech
changed the title
yCodeTech
deleted the
fix/single-line-comment-config-change-in-vscode-june-2025-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
The
lineCommentlanguage config key has changed to be either a string or an object. With the object havingcommentandnoIndentkeys, which was introduced in VS Code's June 2025 release. This breaks the extension when encountering themakefilelanguage, and an error occurs:To fix:
lineCommentis an object with acommentkey inside, if it does then use the string value of thecommentkey. Otherwise, it will use the string value of thelineComment.