refactor: Ngrok::start method to test ngrok for errors before actually running the command for real.

-   Refactor `start` method and test ngrok for errors with the command, and only run the command for real in a new CMD if the test was successful. Otherwise, we need to output the errors to the terminal.

This is required now, since ngrok shipped with valet may be "too old" for some accounts. The ngrok executable will be updated to the latest version in the upcoming 3.2.0 version. But the user can always update valet's ngrok themselves by running `valet ngrok update`.

-   Added `testNgrok` method to run the command (without a new CMD) through Symfony's Process which returns the output.

Author: yCodeTech

cli/Valet/Ngrok.php

@@ -71,7 +71,28 @@ public function start(string $site, int $port, $debug = false, array $options =
 
 		$newCMD = ($debug) ? "" : "start $newCMDtitle";
 
-		$this->cli->passthru("$newCMD $ngrokCommand");
+		// Test ngrok to make sure there's no errors.
+		$testNgrok = $this->testNgrok($ngrokCommand);
+
+		// If test was successful and no errors occurred...
+		if ($testNgrok->isSuccessful()) {
+			// Run the command again for real this time in a new CMD.
+			$this->cli->passthru("$newCMD $ngrokCommand");
+		}
+		else {
+			// Get the errors.
+			$errors = $testNgrok->getOutput();
+
+			// Output the errors.
+			error($errors . "\n");
+
+			// If errors have the ngrok error code of ERR_NGROK_121,
+			// then the error is ngrok executable is "too old" and needs updating.
+			// So output to prompt the user they can update it themselves with the valet command.
+			if (strstr($errors, "ERR_NGROK_121")) {
+				info("To update ngrok yourself, please run `valet ngrok update` and then upgrade the config file by running `valet ngrok config upgrade`\n");
+			}
+		}
 	}
 
 	/**
@@ -171,4 +192,15 @@ protected function hasAuthToken(): bool {
 		}
 		return false;
 	}
+
+	/**
+	 * Test the ngrok command to make sure there's no ngrok errors
+	 *
+	 * @param string $ngrokCommand The ngrok command to run
+	 *
+	 * @return \Valet\ProcessOutput
+	 */
+	private function testNgrok($ngrokCommand) {
+		return $this->cli->run("$ngrokCommand");
+	}
 }