Allow defining default_tags only for rails group #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any chance this could get merged @Envek ? asking for a friend |
|
Thank you and sorry for the wait. Released in 0.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, yabeda-rails plugin do not have into account
:railsgroup default_labels when populating metrics. This change allows defining tags for :rails group, so if you are using other yabeda plugins they don't get populated with them.The main problem here is that we are using
yabeda-railsandyabeda-pumain the same application. If we setdefault_tags, both rails and puma metrics will have that tag populated. If we use the:groupoption setting it to rails (so the tag is only added to rails metrics), the plugin ignores it. This change makes rails plugin aware of:railsgroups metrics.