Skip to content

Conversation

@wuyifan18
Copy link
Contributor

@wuyifan18 wuyifan18 commented Mar 19, 2018

tf.train.Supervisor is deprecated in tensorflow1.6, so I update it using tf.train.MonitoredTrainingSession. Meanwhile, I update the usage of Tensorboard.

tf.train.Supervisor is deprecated in tensorflow1.6, so I update it using tf.train.MonitoredTrainingSession.
@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@wuyifan18 wuyifan18 closed this Mar 19, 2018
@wuyifan18 wuyifan18 deleted the patch-1 branch March 19, 2018 05:58
@wuyifan18 wuyifan18 restored the patch-1 branch March 19, 2018 05:58
@wuyifan18 wuyifan18 reopened this Mar 19, 2018
@wuyifan18 wuyifan18 changed the title Update mnist_dist.py Update mnist_dist.py using tensorflow1.6 Mar 19, 2018
@leewyang
Copy link
Contributor

leewyang commented Mar 19, 2018

Thanks for your contribution! Can you make sure to sign the CLA license?

@wuyifan18
Copy link
Contributor Author

wuyifan18 commented Mar 19, 2018

Thanks for your support! I have signed the CLA license, it works now.

is_chief=(task_index == 0),
checkpoint_dir=logdir,
hooks=hooks,
) as mon_sess:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code throws an error for me (when trying the Standalone instructions). Also, this wouldn't work for args.mode == "inference". Can you update accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show me the error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  File "/Users/leewyang/devpub/TensorFlowOnSpark/examples/mnist/spark/mnist_spark.py", line 18, in <module>
    import mnist_dist
  File "/Users/leewyang/devpub/TensorFlowOnSpark/examples/mnist/spark/mnist_dist.py", line 117
    else:
    ^
IndentationError: expected an indented block

Copy link
Contributor Author

@wuyifan18 wuyifan18 Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'am coming! I have fix some problems and I can run successfully on Hadoop Cluster.
Meanwhile, I also update the usage of Tensorboard. :)

@leewyang leewyang merged commit db0a726 into yahoo:master Mar 20, 2018
@wuyifan18 wuyifan18 deleted the patch-1 branch March 21, 2018 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants