Skip to content

Lazy load resource names. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 16, 2025
Merged

Lazy load resource names. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
960d712
migrate from pods to spm tests
Aug 16, 2025
54bcbd0
disable test for checking if resource can be updated before adding ex…
Aug 16, 2025
11efca1
migrate to standard xctest from quick/nimble
Aug 16, 2025
07ade90
Performance improvements: Make debug name mirroring lazy
Aug 16, 2025
2a600c6
Merge branch 'sal/fixtests' into performance-improvements
Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 0 additions & 41 deletions BGSwift.podspec
View file
Open in desktop

This file was deleted.

37 changes: 21 additions & 16 deletions BGSwift/Classes/BGExtent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ open class BGExtent: Hashable, CustomDebugStringConvertible {

var _added: BGMoment
public var added: BGResource { _added }
var _mirror: Mirror?

public enum Status {
case inactive
Expand All @@ -32,22 +33,6 @@ open class BGExtent: Hashable, CustomDebugStringConvertible {

self.addComponents(from: builder)

var _mirror: Mirror? = Mirror(reflecting: self)
while let mirror = _mirror, mirror.subjectType is BGExtent.Type {
mirror.children.forEach { child in
if let resource = child.value as? (any BGResourceInternal) {
if resource.debugName == nil {
resource.debugName = "\(String(describing: Self.self)).\(child.label ?? "Anonymous_Resource")"
}
} else if let behavior = child.value as? BGBehavior {
if behavior.debugName == nil {
behavior.debugName = "\(String(describing: Self.self)).\(child.label ?? "Anonymous_Behavior")"
}
}
}
_mirror = mirror.superclassMirror
}

#if DEBUG
onExtentCreated?(self)
#endif
Expand Down Expand Up @@ -121,6 +106,26 @@ open class BGExtent: Hashable, CustomDebugStringConvertible {
graph.removeExtent(resources: resources, behaviors: behaviors)
}

internal func loadDebugNames() {
if (_mirror == nil) {
_mirror = Mirror(reflecting: self)
while let mirror = _mirror, mirror.subjectType is BGExtent.Type {
mirror.children.forEach { child in
if let resource = child.value as? (any BGResourceInternal) {
if resource.debugName == nil {
resource.debugName = "\(String(describing: Self.self)).\(child.label ?? "Anonymous_Resource")"
}
} else if let behavior = child.value as? BGBehavior {
if behavior.debugName == nil {
behavior.debugName = "\(String(describing: Self.self)).\(child.label ?? "Anonymous_Behavior")"
}
}
}
_mirror = mirror.superclassMirror
}
}
}

public func sideEffect(file: String = #fileID, line: Int = #line, function: String = #function, _ body: @escaping () -> Void) {
let impulse = BGGraph.impulseString(file: file, line: line, function: function)
sideEffect(impulse, body)
Expand Down
39 changes: 36 additions & 3 deletions BGSwift/Classes/BGResource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,18 @@ public class BGMoment: BGResource, BGResourceInternal {

// MARK: BGResource

public var debugName: String?
var _debugName: String?
public var debugName: String? {
get {
if _debugName != nil {
return _debugName
} else {
self.owner?.loadDebugNames()
return _debugName
}
}
set { _debugName = newValue }
}
public var _event: BGEvent = .unknownPast

// MARK: BGResourceInternal
Expand Down Expand Up @@ -290,7 +301,18 @@ public class BGTypedMoment<Type>: BGResource, BGResourceInternal {

// MARK: BGResource

public var debugName: String?
var _debugName: String?
public var debugName: String? {
get {
if _debugName != nil {
return _debugName
} else {
self.owner?.loadDebugNames()
return _debugName
}
}
set { _debugName = newValue }
}
public var _event: BGEvent = .unknownPast

// MARK: BGResourceInternal
Expand Down Expand Up @@ -408,7 +430,18 @@ public class BGState<Type>: BGResource, BGResourceInternal {

// MARK: BGResource

public var debugName: String?
var _debugName: String?
public var debugName: String? {
get {
if _debugName != nil {
return _debugName
} else {
self.owner?.loadDebugNames()
return _debugName
}
}
set { _debugName = newValue }
}
public var _event: BGEvent = .unknownPast

// MARK: BGResourceInternal
Expand Down
Loading