This repository was archived by the owner on Jul 15, 2019. It is now read-only.
Fix bug in retry request management that didn't return batches to pool#104
Merged
Fix bug in retry request management that didn't return batches to pool#104
Conversation
| Preconditions.checkState(numEvents <= size, "numEvents > size"); | ||
| return numEvents == size; | ||
| PersistEvent get(int idx) { | ||
| Preconditions.checkState(numEvents > 0 && 0 <= idx && idx < numEvents); |
Collaborator
There was a problem hiding this comment.
nitpicking: better to have error message with human readable text there otherwise it throws IllegalArgumentException without any explanation
Contributor
Author
There was a problem hiding this comment.
Done. Also add messages to other preconditions around this class
Collaborator
|
otherwise LGTM |
Add new complete tests for PersistentProcessorHandler component. Also improve readability. Change-Id: Ied72d420bb229c3466b7b89cf14b0756c93b2e31
francisco-perez-sorrosal
force-pushed
the
fix-retry-bug
branch
from
a4ba45f to
f9e6bbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new complete tests for PersistentProcessorHandler component.
Also improve readability.
Change-Id: Ied72d420bb229c3466b7b89cf14b0756c93b2e31