Windows File Path Fix #13
Conversation
index.js
Outdated
| } | ||
| }) | ||
|
|
||
| if (path.sep == "\\") |
There was a problem hiding this comment.
I think there may be a less brittle way of doing this using the https://nodejs.org/api/os.html, however i don't this this is even necessary. Reading the docs for path There appears to be a way to force it to into posix mode. This should fix the path separator issue.
|
Hi @nboehret Thank You for your interest in my project! Iv reviewed your PR and think there may be a cleaner way of going about what your trying to do. Could you take a look and see if my suggestions work. :) |
|
@yarbsemaj You were right! I was looking for something like this but I missed it originally, thank you. This is much simpler and cleaner, imo. Let me know what you think. |
|
@yarbsemaj any chance we could get a new release? |
|
@nboehret Iv published a new release, 0.9.2, with your change in :) |
3 participants
This fix allows for a windows machine to build the adapter and for it to run properly on non-windows servers which the majority of cloud systems run as.
I tested this locally on my windows machine and it worked with build, preview, and serverless deploy and they all worked fine.
I understand if no one else cares for this, my own plan is to use CICD for my deployments and that would be from a linux VM of some sort but at least for now this would help me and possibly others.
Related issue: #12