Skip to content

Conversation

elas7
Copy link
Member

@elas7 elas7 commented Apr 2, 2016

When calling test.js -b aaafalseaaa, and b is a boolean, the value of 'b' is set to false and 'aaafalseaaa' doesn't appear in '_'.

I fixed this by updating the regex to look like the one in the --foo true case, where it works fine.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ca533db on elas7:fix-bool into 48b1e6a on yargs:master.

@bcoe
Copy link
Member

bcoe commented Apr 9, 2016

@elas7 mind rebasing 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 69b18db on elas7:fix-bool into 90b871f on yargs:master.

@bcoe
Copy link
Member

bcoe commented Apr 9, 2016

great fix 👍

@bcoe bcoe merged commit 69941a6 into yargs:master Apr 9, 2016
@elas7 elas7 deleted the fix-bool branch April 10, 2016 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants