Skip to content

fix: use parseOptionalBoolean on YARN_IGNORE_NODE #4052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 1, 2022
Merged

fix: use parseOptionalBoolean on YARN_IGNORE_NODE #4052

merged 4 commits into from
Feb 1, 2022

Conversation

@paul-soporan
Copy link
Member

@paul-soporan paul-soporan commented Feb 1, 2022

What's the problem this PR addresses?

YARN_IGNORE_NODE was compared to 1 instead of being parsed like all env variable configuration settings.

How did you fix it?

We now parse it using miscUtils.parseOptionalBoolean which correctly parses both 1/0 and true/false.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit d64baeb into master Feb 1, 2022
@arcanis arcanis deleted the paul/fix/YARN_IGNORE_NODE branch February 1, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paul-soporan @arcanis