Added docs and rewrited examples for ydb #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive YDB (Yandex Database) support to sqlc, including documentation, updated examples, and improved type handling. The changes enable sqlc to generate idiomatic Go code for YDB database operations with proper named parameter support.
Key changes:
- Added "tinyint" as a supported type alias for "int8" in YDB type mappings
- Enhanced migration handling to split and execute statements individually
- Created complete examples for ondeck, jets, booktest, and authors packages demonstrating YDB usage
- Added getting-started tutorial documentation for YDB
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/sqltest/local/ydb.go | Removed hardcoded connection options and added statement splitting for migrations |
| internal/codegen/golang/ydb_type.go | Added "tinyint" type alias support for int8 |
| examples/ondeck/ydb/* | New complete ondeck example with YDB-specific schema, queries, and tests |
| examples/jets/ydb/* | New jets example demonstrating basic CRUD operations with YDB |
| examples/booktest/ydb/* | New booktest example showing complex queries including joins and slices |
| examples/authors/ydb/* | Updated authors example with improved schema using Serial type and named parameters |
| docs/tutorials/getting-started-ydb.md | New comprehensive tutorial for getting started with YDB |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.