feat: use groups handler for storage #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1160-use-storage-groups
branch
5 times, most recently
from
69e6ea2 to
dfa54b9
Compare
astandrik
reviewed
Sep 4, 2024
src/containers/App/Content.tsx
Outdated
| function GetCapabilities() { | ||
| capabilitiesApi.useGetClusterCapabilitiesQuery(undefined); | ||
| return null; | ||
| function GetCapabilities({children}: {children: React.ReactNode}) { |
There was a problem hiding this comment.
Now the whole interface is blocked by capabilities response
I think it would better to do it in background without impact on functionality that doesn't rely on capabilities (endpoint may timeout or throw an error)
astandrik
reviewed
Sep 4, 2024
| options: AxiosOptions, | ||
| getState?: GetState, | ||
| ) { | ||
| const groupsHandlerVersion = |
There was a problem hiding this comment.
wouldnt it be better to create enableSomeFunctionality and hook with
return useGetFeatureVersion('/viewer/sth') > 2;
and to pass these flags to functions that depend on it
instead of mixing redux state operations with api calls by passing getState function
astandrik
reviewed
Sep 4, 2024
| v1 = 'v1', | ||
| v2 = 'v2', // only this versions works with sorting | ||
| } | ||
| export type EVersion = 'v1' | 'v2'; // only v2 versions works with sorting |
artemmufazalov
force-pushed
the
1160-use-storage-groups
branch
from
dfa54b9 to
d3e69bc
Compare
astandrik
reviewed
Sep 11, 2024
| }: StorageRequestParams & {useGroupsHandler?: boolean}, | ||
| options: AxiosOptions, | ||
| ) { | ||
| if (useGroupsHandler && version !== 'v1') { |
There was a problem hiding this comment.
useGroupsHandler really looks like name of react hook
was really confused why we pass hooks to api =)
Please change useGroupsHandler to something else >_<
astandrik
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1160
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 78.87 MB | Main: 78.86 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information