fix: add implicit transaction_mode to query settings #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Aug 30, 2024
Comment on lines
152
to
155
| // deprecated https://github.com/ydb-platform/ydb-embedded-ui/issues/1239 | ||
| isolationLevel: { | ||
| title: '', | ||
| }, |
There was a problem hiding this comment.
Why do you need it here? Probably, you can remove this field in useLastQueryExecutionSettings, then it should not appear anywhere
Comment on lines
+13
to
+17
| transactionMode: lastStorageSettings.transactionMode, | ||
| queryMode: lastStorageSettings.queryMode, | ||
| statisticsMode: lastStorageSettings.statisticsMode, | ||
| tracingLevel: lastStorageSettings.tracingLevel, | ||
| timeout: lastStorageSettings.timeout, |
There was a problem hiding this comment.
{...lastStorageSettings, isolationLevel: undefined}?
There was a problem hiding this comment.
I think it would be better to pass fields explicitly not to focus on isolationLevel field
otherwise it looks like a specific fix for specific bug in a common code space
artemmufazalov
approved these changes
Aug 30, 2024
astandrik
deleted the
astandrik.add-implicit-transaction_mode-to-query-settings-1239
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1239
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 78.84 MB | Main: 78.84 MB
Diff: +0.00 MB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information