feat(Node): enable nodes switch in storage tab on node page #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareyu
changed the title
artemmufazalov
requested changes
Sep 10, 2024
Comment on lines
56
to
60
| const hasStorage = node?.Roles?.find((el) => el === STORAGE_ROLE); | ||
|
|
||
| const nodePages = hasStorage ? NODE_PAGES : NODE_PAGES.filter((el) => el.id !== STORAGE); | ||
|
|
||
| const actualNodeTabs = nodePages.map((page) => { |
There was a problem hiding this comment.
Compute nodes doesn't have any disks, there is no need for storage tab for them. All node general info can be viewed on Info tab, there is no need for storage tab for this case as well
artemmufazalov
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structuretabgroups/nodesswitch on node pagedemo
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔽
Current: 78.86 MB | Main: 78.87 MB
Diff: 0.01 MB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information