Skip to content

Conversation

@DaryaVorontsova
Copy link
Contributor

@DaryaVorontsova DaryaVorontsova commented Dec 2, 2025

Greptile Overview

Greptile Summary

Cleaned up SQL query templates by removing the unused indentBlock helper function and reformatting streaming query templates to use blank lines for visual separation instead of indentation. The changes align the DO BEGIN / END DO; blocks consistently across createStreamingQueryTemplate and alterStreamingQueryText functions, improving readability and consistency.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes only involve formatting SQL template strings and removing an unused helper function, with no impact on runtime logic or functionality
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
src/containers/Tenant/utils/schemaQueryTemplates.ts 5/5 Removed unused indentBlock function and aligned SQL templates with consistent blank lines instead of indentation

Sequence Diagram

sequenceDiagram
    participant User
    participant SchemaViewer
    participant QueryTemplates
    participant MonacoEditor
    
    User->>SchemaViewer: Select template action
    SchemaViewer->>QueryTemplates: Call createStreamingQueryTemplate() or alterStreamingQueryText()
    QueryTemplates->>QueryTemplates: Generate SQL template with proper formatting
    Note over QueryTemplates: Removed indentBlock()<br/>Added blank lines for alignment
    QueryTemplates-->>SchemaViewer: Return formatted SQL string
    SchemaViewer->>MonacoEditor: Insert template into editor
    MonacoEditor-->>User: Display formatted SQL query
Loading

Context used:

  • Rule from dashboard - Remove unused interfaces and CSS classes that are added during development. Clean up duplicate code ... (source)

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 375 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 62.33 MB | Main: 62.33 MB
Diff: 0.31 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@DaryaVorontsova DaryaVorontsova linked an issue Dec 2, 2025 that may be closed by this pull request
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@DaryaVorontsova DaryaVorontsova added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 2deae10 Dec 3, 2025
10 checks passed
@DaryaVorontsova DaryaVorontsova deleted the fix-streaming branch December 3, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix streaming query

3 participants