fix: add setting for query parameter output_chunk_max_size #3164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
requested review from
Raubzeug,
adameat and
artemmufazalov
as code owners
Copilot finished reviewing on behalf of
astandrik
December 3, 2025 08:47
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new configurable query setting outputChunkMaxSize to control the maximum size of output chunks in streaming query responses, addressing issue #3163.
Key Changes:
- Added
outputChunkMaxSizesetting with a default value of 1,000,000 bytes - Implemented proper validation (positive integer) and URL parameter persistence with Zod schemas
- Created UI form field with user-friendly input validation and internationalized labels
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/query.ts |
Added outputChunkMaxSize to default settings (1M bytes), validation schema (positive integer), and restore schema with fallback handling |
src/store/reducers/query/query.ts |
Updated streaming chunk size constant to use new setting; modified API call to pass user-configured value with proper numeric validation |
src/containers/Tenant/Query/QuerySettingsDialog/i18n/en.json |
Added English translations for field label and unit ("bytes") |
src/containers/Tenant/Query/QuerySettingsDialog/i18n/ru.json |
Added Russian translations for field label and unit ("байт") |
src/containers/Tenant/Query/QuerySettingsDialog/constants.ts |
Registered field configuration with translated title |
src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx |
Added form field with number input, validation state handling, and unit label display |
Copilot finished reviewing on behalf of
astandrik
December 3, 2025 08:53
src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx
Outdated
Show resolved
Hide resolved
artemmufazalov
previously approved these changes
Dec 3, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx
Outdated
Show resolved
Hide resolved
Copilot finished reviewing on behalf of
astandrik
December 3, 2025 09:11
Raubzeug
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3163
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 62.33 MB | Main: 62.33 MB
Diff: +4.84 KB (0.01%)
ℹ️ CI Information