Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3247
Greptile Summary
Fixed bug where
META_BACKENDvalue ofundefinedwas coerced to the string"undefined"in URL construction, causing malformed meta request URLs like/cluster/undefined/proxy/....META_BACKEND ?? ''into ametaBackendPrefixvariable to ensure it's always a string before template literal interpolationConfidence Score: 5/5
Important Files Changed
Sequence Diagram
sequenceDiagram participant Client participant BaseMetaAPI participant Store participant Window Note over Window: REACT_APP_META_BACKEND="undefined" Window->>Store: window.meta_backend = "undefined" Store->>Store: parseJson("undefined") returns undefined Store->>Store: META_BACKEND = undefined Client->>BaseMetaAPI: getPath(path, clusterName) BaseMetaAPI->>Store: Import META_BACKEND alt Before Fix BaseMetaAPI->>BaseMetaAPI: Template literal: ${META_BACKEND}/proxy/... Note over BaseMetaAPI: undefined coerced to string "undefined" BaseMetaAPI-->>Client: "/env/undefined/proxy/cluster/name/path" else After Fix BaseMetaAPI->>BaseMetaAPI: metaBackendPrefix = META_BACKEND ?? '' BaseMetaAPI->>BaseMetaAPI: Template literal: ${metaBackendPrefix}/proxy/... Note over BaseMetaAPI: Empty string used instead BaseMetaAPI-->>Client: "/env/proxy/cluster/name/path" endCI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 62.59 MB | Main: 62.59 MB
Diff: +0.09 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information