-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add show more expandable section #3265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } from './constants'; | ||
| import i18n from './i18n'; | ||
|
|
||
| const ALWAYS_METRICS_KEYS = ['CPU', 'Memory', 'ReadThroughput', 'Network'] as const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does always metrics mean?
Could you please add comment or provide more readable const name =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is general metrics keys, that are always visible )) I fix it to GENERAL_METRICS_KEYS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
src/containers/Tenant/Diagnostics/Overview/TableInfo/TableInfo.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
Stand: https://nda.ya.ru/t/hmyjN_7G7QVFny
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 62.63 MB | Main: 62.62 MB
Diff: +8.40 KB (0.01%)
ℹ️ CI Information