fix(VirtualTable): optimise requests #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
virtual-table-reduce-requests
branch
2 times, most recently
from
9aec1de to
2f27595
Compare
Raubzeug
requested changes
Feb 1, 2024
| const [error, setError] = useState<IResponseError>(); | ||
|
|
||
| const [pendingRequests, setPendingRequests] = useState<Record<string, NodeJS.Timeout>>({}); | ||
| const pendingRequests = useRef<Record<string, ReturnType<typeof setTimeout>>>({}); |
Contributor
There was a problem hiding this comment.
You also need to cancel all pendingRequest when component unmounts.
artemmufazalov
force-pushed
the
virtual-table-reduce-requests
branch
from
2f27595 to
ad483bd
Compare
Raubzeug
approved these changes
Feb 1, 2024
artemmufazalov
force-pushed
the
virtual-table-reduce-requests
branch
from
ad483bd to
ae08106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
VirtualTablecould be seen here: https://nda.ya.ru/t/se1OYEka74UxroEnsure that experiment "Use table with data load on scroll for Nodes and Storage cluster tabs" is turned on before reviewing this table