fix(TopQueries): use EndTime #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
top-queries-filters
branch
from
8f82f5a to
ec5020b
Compare
Raubzeug
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test stand: https://nda.ya.ru/t/h3ivZEO074jcAL
Currently we use
IntervalEndforTopQueriesfilters, but in the table we useEndTime. These values are different, so filters could work unexpectedly.For example, I set filter from 11.00 to 12.30. Queries, that was ended in 12.10 and 12.15 won't be displayed, because they have
IntervalEnd13.00Before:
Now:
