feat: show different page titles on different pages #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Feb 27, 2024
src/containers/Tablet/Tablet.tsx
Outdated
Comment on lines
161
to
163
| <title>{`${id} - ${ | ||
| tenantName || queryClusterName || i18n('tablet.header') | ||
| }`}</title> |
There was a problem hiding this comment.
For me i18n('tablet.header') is excessive here. It is not an alternative to tenant or cluster name if they are missing. For me it's more like TabletId - YDB Monitoring or TabletId - Cluster - YDB Monitoring in this case. Or if TabletId is not obvious indicator, something like TabletId - Tablet - TenantName / ClusterName - YDB Monitoring (Tablet is always present)
artemmufazalov
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #662