feat: add binary data in plain text display #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovaspace
commented
Feb 29, 2024
artemmufazalov
requested changes
Mar 1, 2024
ValeraS
requested changes
Mar 1, 2024
artemmufazalov
previously approved these changes
Mar 4, 2024
ValeraS
requested changes
Mar 4, 2024
Comment on lines
9
to
14
| export const ClusterModeGuard: FC<ClusterModeGuardProps> = ({children, mode}) => | ||
| useTypedSelector((state) => | ||
| mode === 'single' ? state.singleClusterMode : !state.singleClusterMode, | ||
| ) | ||
| ? (children as ReactElement) | ||
| : null; |
There was a problem hiding this comment.
it's difficult to read such ternaries. Let's rewrite it like this:
Suggested change
| export const ClusterModeGuard: FC<ClusterModeGuardProps> = ({children, mode}) => | |
| useTypedSelector((state) => | |
| mode === 'single' ? state.singleClusterMode : !state.singleClusterMode, | |
| ) | |
| ? (children as ReactElement) | |
| : null; | |
| export function ClusterModeGuard({children, mode}: ClusterModeGuardProps) { | |
| const isMode = useTypedSelector((state) => | |
| mode === 'single' ? state.singleClusterMode : !state.singleClusterMode, | |
| ); | |
| return isMode ? <React.Fragment>{children}</React.Fragment> : null; | |
| } |
There was a problem hiding this comment.
Implemented in 66eade8.
Co-authored-by: Valerii Sidorenko <balepas@nebius.com>
ValeraS
previously approved these changes
Mar 4, 2024
ValeraS
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.