feat: add YQL autocomplete #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
force-pushed
the
add-yql-autocomplete
branch
from
db72939 to
feed63e
Compare
|
Test stand: https://nda.ya.ru/t/8dR2DKuN74wsF6 |
artemmufazalov
requested changes
Mar 13, 2024
artemmufazalov
requested changes
Mar 13, 2024
Comment on lines
68
to
80
| let completionProvider: monaco.IDisposable | undefined; | ||
|
|
||
| function disableCodeSuggestions(): void { | ||
| if (completionProvider) { | ||
| completionProvider.dispose(); | ||
| } | ||
| } | ||
|
|
||
| export function registerYQLCompletionItemProvider(database: string) { | ||
| disableCodeSuggestions(); | ||
| completionProvider = monaco.languages.registerCompletionItemProvider('sql', { | ||
| triggerCharacters: [' ', '\n', '', ',', '.', '`', '('], | ||
| provideCompletionItems: createProvideSuggestionsFunction(), | ||
| provideCompletionItems: createProvideSuggestionsFunction(database), |
There was a problem hiding this comment.
Why it's here, but not in QueryEditor component?
There was a problem hiding this comment.
I decided to do it in the closest place to tenantName emergence.
There was a problem hiding this comment.
In this case, Tenant component seems to be a better place, since it's parent for all Tenant page content
There was a problem hiding this comment.
This comment should be originally addressed to ObjectGeneral file)
There was a problem hiding this comment.
Do you suggest to lift query string parsing from ObjectGeneral to Tenant? As for me it make sense.
There was a problem hiding this comment.
Yes.
There is already query parsing in Tenant, tenantName could be passed in props
artemmufazalov
previously approved these changes
Mar 14, 2024
Raubzeug
force-pushed
the
add-yql-autocomplete
branch
from
fd479cd to
a593d16
Compare
Raubzeug
force-pushed
the
add-yql-autocomplete
branch
from
a593d16 to
8fd2bb7
Compare
artemmufazalov
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #611