fix(Tablet): correctly process error in dialog action #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
fix-tablet-dialog
branch
from
031006a to
d911886
Compare
Raubzeug
previously approved these changes
Mar 15, 2024
| }; | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
It contains two components CriticalActionDialog and Button
| const [buttonLoading, setButtonLoading] = useState(false); | ||
|
|
||
| const handleConfirmAction = () => { | ||
| setButtonLoading(true); |
There was a problem hiding this comment.
What if no onConfirmActionSuccess is passed and handleConfirmActionError didn't fired?
There was a problem hiding this comment.
Thanks, in this case button in infinite loading state, I will fix it
artemmufazalov
force-pushed
the
fix-tablet-dialog
branch
from
d911886 to
1700640
Compare
Raubzeug
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728
Test stand (normal behaviour): https://nda.ya.ru/t/fDzumJa_74xcbY
Test stand (error behaviour): https://nda.ya.ru/t/NZOSqOgA74xcn9
How to check: run
Restartbutton action