feat: add VDisk page #773
Merged
feat: add VDisk page #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
vdisk-page
branch
4 times, most recently
from
b3884a2 to
6cf005b
Compare
ValeraS
requested changes
Apr 2, 2024
| const ClusterNodesMapContext = createContext<NodesMap | undefined>(undefined); | ||
|
|
||
| /** NodesMap - almost constant cluster nodes to hosts mapping */ | ||
| export function ClusterNodesMapContextProvider({children}: ClusterNodesMapContextProps) { |
There was a problem hiding this comment.
Why do we need context? Trigger getNodesList in the component that uses this provider and loaded data will be in global store.
artemmufazalov
force-pushed
the
vdisk-page
branch
from
6cf005b to
14f2775
Compare
ValeraS
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #617