feat(formatNumber): render numbers with spaces instead of comas #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunga
force-pushed
the
better-bytes-rendering
branch
from
66f0bea to
b251244
Compare
| box-sizing: border-box; | ||
|
|
||
| // Make all numbers in the app monospace | ||
| font-variant-numeric: tabular-nums; |
Member
There was a problem hiding this comment.
I deleted font for TopShards table. It's different from font throughout the app. Instead I set monospace numbers everywhere in the app
| it('should convert to size', () => { | ||
| expect(formatBytes({value: 100_000, size: 'b'})).toBe('100,000 B'); | ||
| expect(formatBytes({value: 100_000_000_000_000, size: 'gb'})).toBe('100,000 GB'); | ||
| expect(formatBytes({value: 100_000, size: 'b'})).toBe('100 000 B'); |
Comment on lines
4
to
11
| import {Lang, i18n} from './i18n'; | ||
|
|
||
| // Set space delimeter for all locales possible in project | ||
| Object.values(Lang).forEach((value) => { | ||
| if (numeral.locales[value]) { | ||
| numeral.locales[value].delimiters.thousands = ' '; | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
You configured numeral almost correctly, but it seems you deleted "," in format string. In format "," is delimiter sign, not delimiter itself, so no delimiter was applied.
I made more simple delimiter override, so it should work and no so complex for future support
artemmufazalov
force-pushed
the
better-bytes-rendering
branch
from
7e94038 to
8127004
Compare
Member
|
artemmufazalov
force-pushed
the
better-bytes-rendering
branch
from
8127004 to
23e0ef8
Compare
artemmufazalov
approved these changes
Mar 29, 2024
Contributor
Author
|
Cool thanks for the improvements 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.