Skip to content

feat!: update to uikit 6 #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2024
Merged

feat!: update to uikit 6 #789

merged 4 commits into from
Apr 10, 2024

Conversation

@ValeraS
Copy link
Collaborator

@ValeraS ValeraS commented Apr 2, 2024 •
edited by artemmufazalov
Loading

Closes #790, closes #650

artemmufazalov
artemmufazalov requested changes Apr 2, 2024
View reviewed changes
src/components/TableWithControlsLayout/TableWithControlsLayout.tsx
Copy link
Member

@artemmufazalov artemmufazalov Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataTable columns initially stick to left, they blink on load, Skeleton isn’t shown

@artemmufazalov
Copy link
Member

artemmufazalov commented Apr 2, 2024

Please, split such PRs apart in the future, GitHub cannot do normal virtualisation, everything lags (it renders 150k DOM elements on first load and 250k when diffs are loaded). So I cannot event leave a comment without waiting for some time

@ValeraS
Copy link
Collaborator Author

ValeraS commented Apr 2, 2024

Please, split such PRs apart in the future, GitHub cannot do normal virtualisation, everything lags (it renders 150k DOM elements on first load and 250k when diffs are loaded). So I cannot event leave a comment without waiting for some time

image

You can view and comment changes locally or in a codespace.

@artemmufazalov
Copy link
Member

artemmufazalov commented Apr 10, 2024

Please, set sortable={false} to both TableColumnSetup, columns reordering isn't supported

@artemmufazalov
Copy link
Member

artemmufazalov commented Apr 10, 2024

Some button name is needed

image

artemmufazalov
artemmufazalov reviewed Apr 10, 2024
View reviewed changes
@ValeraS ValeraS merged commit 1a3154d into main Apr 10, 2024
@ValeraS ValeraS deleted the feat/uikit6 branch April 10, 2024 13:48
@ydb-platform-bot ydb-platform-bot mentioned this pull request Apr 10, 2024
Merged
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

@vovaspace vovaspace Awaiting requested review from vovaspace

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refresh dependencies Update prettier, eslint and stylelint

3 participants

@ValeraS @artemmufazalov