fix: fix buttons incorrect align in Nodes and Tenants tables #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
May 20, 2024
Comment on lines
48
to
56
| a { | ||
| text-decoration: none; | ||
|
|
||
| color: var(--g-color-text-link); | ||
| } | ||
|
|
||
| a:hover { | ||
| color: var(--g-color-text-link-hover); | ||
| } |
Member
Author
There was a problem hiding this comment.
Move styles inside link class, so link colors won't apply to buttons
Contributor
There was a problem hiding this comment.
Why should we define these styles? Is it possible to use proper uikit components with needed styles?
Member
Author
There was a problem hiding this comment.
React-router Link was used, it doesn't have proper styles. Replaced it with out link wrapper and removed unneeded styles
Raubzeug
requested changes
May 21, 2024
Comment on lines
48
to
56
| a { | ||
| text-decoration: none; | ||
|
|
||
| color: var(--g-color-text-link); | ||
| } | ||
|
|
||
| a:hover { | ||
| color: var(--g-color-text-link-hover); | ||
| } |
Contributor
There was a problem hiding this comment.
Why should we define these styles? Is it possible to use proper uikit components with needed styles?
artemmufazalov
force-pushed
the
829-fix-align
branch
from
82f04f0 to
975bcaa
Compare
Raubzeug
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829
Before:
After:
