feat: disable controls for users with viewer rights #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
828-disable-buttons-for-viewers
branch
2 times, most recently
from
9681e29 to
ea06020
Compare
Raubzeug
requested changes
May 29, 2024
| onConfirmAction={handleRestart} | ||
| onConfirmActionSuccess={handleAfterRestart} | ||
| buttonDisabled={!nodeId || !pDiskId} | ||
| buttonDisabled={!nodeId || !pDiskId || !isUserAllowedToMakeChanges} |
Contributor
There was a problem hiding this comment.
Here and farther I think we should add a tooltip with information why is this button disabled.
artemmufazalov
force-pushed
the
828-disable-buttons-for-viewers
branch
from
ea06020 to
c129e58
Compare
Raubzeug
previously approved these changes
Jun 4, 2024
| buttonDisabled={!nodeId || !pDiskId || !isUserAllowedToMakeChanges} | ||
| buttonView="normal" | ||
| dialogContent={pDiskPageKeyset('restart-pdisk-dialog')} | ||
| withPopover={true} |
artemmufazalov
force-pushed
the
828-disable-buttons-for-viewers
branch
from
56aa5ce to
b34511d
Compare
Raubzeug
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #828
Example of UI, where buttons disabled: https://nda.ya.ru/t/YumLNk9p76FUc4
Changes affect tablet page, diagnostics tablets table, PDisk and VDisk pages
Tablet page:
PDisk page:
