feat: suggest views and table settings #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #858 |
Raubzeug
force-pushed
the
improve-autocomplete
branch
from
a500ab0 to
6477e8e
Compare
artemmufazalov
approved these changes
Jun 3, 2024
artemmufazalov
requested changes
Jun 3, 2024
|
closes #867 |
artemmufazalov
requested changes
Jun 4, 2024
Raubzeug
force-pushed
the
improve-autocomplete
branch
from
68383f0 to
a38dd10
Compare
| rangeToInsertSuggestion: monaco.IRange, | ||
| entityType: YQLEntity, | ||
| ): Promise<monaco.languages.CompletionItem[]> { | ||
| const tableHints = await getEntitySettings(entityType); |
There was a problem hiding this comment.
Please, rename tableHints to entityHints
artemmufazalov
approved these changes
Jun 4, 2024
This was
linked to
issues
Jun 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.