feat(Navigation): relocate tenant nav to main space #936
Conversation
|
It seems it's not navigation any longer and not a part of navigation. Let's rename it to let say |
| "controls.query-mode-selector_type": "Query type:", | ||
|
|
||
| "tabs.newQuery": "Query", | ||
| "sections.query": "Query", |
There was a problem hiding this comment.
This translations should not be here. The better place is /Tenant/ObjectGeneral/TenantWorkModes/i18n
And please remove old translations from AsideNavigation translations.
| size="l" | ||
| className={b('body')} | ||
| defaultValue={getCurrentItem().id} | ||
| options={Object.values(navigationItems).map(transformItemToOption)} |
There was a problem hiding this comment.
Why do you need to use Object.values here?
There was a problem hiding this comment.
Forgot to change this line
I used to make an object from the array (array to indexed), but dropped the idea eventually
| id: TENANT_PAGES_IDS.query, | ||
| title: i18n('pages.query'), | ||
| icon: Terminal, | ||
| iconSize: 20, |
There was a problem hiding this comment.
Please remove this property, it is set for all items in a row in return.
There was a problem hiding this comment.
That's the original code, I made no changes xd
There was a problem hiding this comment.
I agree it should be done this way btw
Raubzeug
force-pushed
the
811-relocate-nav
branch
2 times, most recently
from
dfb0e22 to
895ff85
Compare
Raubzeug
force-pushed
the
811-relocate-nav
branch
from
895ff85 to
1cc4ccc
Compare
No description provided.