Skip to content

feat: add different auth methods for external datasource #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2025
Merged

feat: add different auth methods for external datasource #2982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3715f6
feat: add aws auth method
Raubzeug Oct 17, 2025
7278eaf
types
Raubzeug Oct 17, 2025
07c0b59
add other methods
Raubzeug Oct 17, 2025
73b5921
types
Raubzeug Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/containers/Tenant/Info/ExternalDataSource/ExternalDataSource.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,28 @@ const prepareExternalDataSourceSummary = (data: TEvDescribeSchemeResult) => {
return info;
};

function getAuthMethodValue(data: TEvDescribeSchemeResult) {
const {Auth} = data.PathDescription?.ExternalDataSourceDescription || {};
if (Auth?.ServiceAccount) {
return i18n('external-objects.auth-method.service-account');
}
if (Auth?.Aws) {
return i18n('external-objects.auth-method.aws');
}
if (Auth?.Token) {
return i18n('external-objects.auth-method.token');
}
if (Auth?.Basic) {
return i18n('external-objects.auth-method.basic');
}
if (Auth?.MdbBasic) {
return i18n('external-objects.auth-method.mdb-basic');
}
return i18n('external-objects.auth-method.none');
}

const prepareExternalDataSourceInfo = (data: TEvDescribeSchemeResult): InfoViewerItem[] => {
const {Location, Auth} = data.PathDescription?.ExternalDataSourceDescription || {};
const {Location} = data.PathDescription?.ExternalDataSourceDescription || {};

return [
...prepareExternalDataSourceSummary(data),
Expand All @@ -47,9 +67,7 @@ const prepareExternalDataSourceInfo = (data: TEvDescribeSchemeResult): InfoViewe
},
{
label: i18n('external-objects.auth-method'),
value: Auth?.ServiceAccount
? i18n('external-objects.auth-method.service-account')
: i18n('external-objects.auth-method.none'),
value: getAuthMethodValue(data),
},
];
};
Expand Down
4 changes: 4 additions & 0 deletions src/containers/Tenant/Info/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
"external-objects.auth-method": "Auth Method",
"external-objects.auth-method.none": "None",
"external-objects.auth-method.service-account": "Service Account",
"external-objects.auth-method.aws": "AWS",
"external-objects.auth-method.token": "Token",
"external-objects.auth-method.basic": "Basic",
"external-objects.auth-method.mdb-basic": "MDB Basic",

"view.query-text": "Query Text",

Expand Down
25 changes: 25 additions & 0 deletions src/types/api/schema/externalDataSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ export interface TExternalDataSourceDescription {
interface TAuth {
None?: NoneAuth;
ServiceAccount?: ServiceAccountAuth;
Aws?: AwsAuth;
Token?: Token;
MdbBasic?: MdbBasic;
Basic?: Basic;
}

interface NoneAuth {}
Expand All @@ -22,3 +26,24 @@ interface ServiceAccountAuth {
Id?: string;
SecretName?: string;
}
interface AwsAuth {
AwsSecretAccessKeySecretName?: string;
AwsRegion?: string;
AwsAccessKeyIdSecretName?: string;
}

interface Basic {
Login?: string;
PasswordSecretName?: string;
}

interface MdbBasic {
ServiceAccountId?: string;
ServiceAccountSecretName?: string;
Login?: string;
PasswordSecretName?: string;
}

interface Token {
TokenSecretName?: string;
}
Loading