fix: progress is not shown for export #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
requested review from
Raubzeug,
adameat and
artemmufazalov
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Raubzeug
requested changes
Nov 18, 2025
| kind: OperationKind; | ||
| }): DataTableColumn<TOperation>[] { | ||
| const isBuildIndex = kind === 'buildindex'; | ||
| const isImportOrExport = ['import/s3', 'export/s3', 'export/yt'].includes(kind); |
Contributor
There was a problem hiding this comment.
maybe take constant out of function?
|
|
||
| const tooltipContent = isBuildIndex ? getDescriptionTooltip(row) || row.id : row.id; | ||
| const tooltipContent = isBuildIndex | ||
| ? getDescriptionTooltip(row.metadata as IndexBuildMetadata | undefined) || |
Contributor
There was a problem hiding this comment.
here and farther is it possible to get rid of typecast?
Contributor
There was a problem hiding this comment.
3 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Copilot finished reviewing on behalf of
astandrik
November 18, 2025 08:57
Raubzeug
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3072
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 66.12 MB | Main: 66.11 MB
Diff: +0.01 MB (0.02%)
ℹ️ CI Information