Skip to content

Conversation

@Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Nov 18, 2025

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 375 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 66.11 MB | Main: 66.11 MB
Diff: +0.12 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Greptile Summary

  • Added streaming_query entity type support to YQL Monaco autocomplete for querying streaming queries in the editor
  • Fixed flaky sidebar test by increasing animation timeout from 500ms to 1000ms

Confidence Score: 5/5

  • This PR is safe to merge with no significant risks
  • Simple additive changes that extend existing patterns without modifying core logic, plus a straightforward test timeout adjustment
  • No files require special attention

Sequence Diagram

sequenceDiagram
    participant User
    participant MonacoEditor
    participant CompletionProvider
    participant AutocompleteAPI
    participant YDBBackend
    
    User->>MonacoEditor: Types in YQL editor
    MonacoEditor->>CompletionProvider: Request autocomplete suggestions
    CompletionProvider->>CompletionProvider: Filter needed entity types (includes streamingQuery)
    CompletionProvider->>AutocompleteAPI: fetchEntities(prefix, neededTypes)
    AutocompleteAPI->>YDBBackend: GET /viewer/json/autocomplete
    YDBBackend-->>AutocompleteAPI: Return entities (including streaming_query)
    AutocompleteAPI->>CompletionProvider: Filter entities by type mapping
    CompletionProvider-->>MonacoEditor: Return filtered suggestions
    MonacoEditor-->>User: Display autocomplete dropdown
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@Raubzeug Raubzeug added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit 96ceae4 Nov 18, 2025
9 checks passed
@Raubzeug Raubzeug deleted the streaming-autocomplete branch November 18, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants