Skip to content

Conversation

@Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Nov 18, 2025

closes #2541

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 66.13 MB | Main: 66.12 MB
Diff: +2.94 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug
Copy link
Contributor Author

@greptile-review

@Raubzeug Raubzeug requested a review from Copilot November 18, 2025 14:26
Copilot finished reviewing on behalf of Raubzeug November 18, 2025 14:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes virtualization problems in the YDB Embedded UI by introducing a new useResizeObserverTrigger hook that dispatches window resize events to force virtualized components to recalculate their visible items after layout changes such as panel expansions/collapses or fullscreen state changes.

Key changes:

  • Created a new utility hook useResizeObserverTrigger that uses double requestAnimationFrame and optional timeout to ensure resize events are dispatched after layout recalculation
  • Integrated the hook in three locations: Fullscreen component, ClusterOverview component, and PaneVisibilityToggleButtons component
  • Replaced inline resize event dispatching logic in Fullscreen.tsx with the new hook

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/utils/hooks/useResizeObserverTrigger.ts New hook that triggers window resize events when dependencies change, with configurable timeout for animation completion
src/components/Fullscreen/Fullscreen.tsx Refactored to use the new hook instead of inline resize event dispatching
src/containers/Cluster/ClusterOverview/ClusterOverview.tsx Added hook usage with 110ms timeout to handle Disclosure component animations
src/containers/Tenant/utils/paneVisibilityToggleHelpers.tsx Added hook usage to trigger resize when pane collapse state changes

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@Raubzeug
Copy link
Contributor Author

@greptile-review

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@Raubzeug Raubzeug added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 14ec98a Nov 19, 2025
9 checks passed
@Raubzeug Raubzeug deleted the virtualization-bugs branch November 19, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Data missing in query fullscreen mode

3 participants