Update SLO Action #1939
Merged
Update SLO Action #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1939 +/- ##
==========================================
- Coverage 74.01% 72.65% -1.36%
==========================================
Files 392 392
Lines 34343 34343
==========================================
- Hits 25418 24951 -467
- Misses 7807 8253 +446
- Partials 1118 1139 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github.com/ydb-platform/ydb-go-sdk/v3/querycompatible changesImplicitTxControl: added summaryInferred base version: v3.120.0 |
polRk
force-pushed
the
update-slo-action
branch
2 times, most recently
from
85df6d0 to
b7dc59c
Compare
🌋 SLO Test ResultsStatus: ⚪ 6 workloads tested • All clear| | Workload | Metrics | Regressions | Improvements | Links |
|
kprokopenko
reviewed
Nov 24, 2025
- Update workflow to build current and baseline workload images - Add ref parameter to track version in metrics - Replace Prometheus push with OTLP HTTP export - Update dependencies to use OpenTelemetry SDK - Configure PeriodicReader for automatic metric export - Add ref as metric attribute for baseline comparison
- Add parallel testing of current and baseline SDK versions - Build Docker images for workloads instead of binary compilation - Auto-detect baseline commit using git merge-base with master - Add ref labels to metrics for version tracking in Prometheus - Migrate from Prometheus client to OpenTelemetry OTLP HTTP - Copy current build infrastructure (Dockerfile, go.mod, internal) to baseline - Add container log collection for debugging - Update workload execution to run in Docker containers - Configure proper network connectivity with YDB cluster
- Add extra time for graceful shutdown during container waits - Implement timeout for waiting on current and baseline containers to improve reliability
- Add workload_current_ref to capture the current reference - Introduce workload_baseline_ref to track the baseline reference from outputs
- Comment out conditional for workflow run success - Enhance timeout handling for current and baseline containers - Introduce error handling for container wait timeouts - Update exit code checks to determine overall success
- Update logging to show the last 15 lines for current and baseline containers - Adjust timeout for graceful shutdown from 120 seconds to 30 seconds - Remove overall success determination logic for cleaner workflow execution
- Decrease read timeout from 1000ms to 500ms - Reduce write timeout from 1000ms to 100ms for improved performance
- Remove unnecessary timeout logic for container waits - Simplify shutdown process by directly killing running containers - Enhance logging for container status during shutdown
…tions - Add write permission for checks in slo-report.yml - Modify slo.yml to conditionally use self-hosted runner for specific user
- Remove unnecessary sleep commands before logging - Simplify container stop logic with a direct timeout option - Enhance shutdown handling by ensuring graceful termination of containers
- Change the runner configuration to always use 'ubuntu-latest' instead of conditionally using a self-hosted runner for a specific user.
- Update the SLO workflow to include steps for removing existing Docker packages, installing Docker, and adding yq for YAML processing. - Ensure version checks for Docker and yq are displayed for verification.
- Change the action references in slo-report.yml and slo.yml to a specific commit for consistency and stability. - Remove unnecessary Docker package removal step from the SLO workflow.
…d yq - Change the installation steps to use specific versions for yq, Docker Buildx, and Docker Compose for consistency. - Remove outdated installation commands and streamline the dependency installation process.
…er configuration - Increase default write requests per second (RPS) from 100 to 1000 for improved performance. - Decrease read timeout from 500ms to 100ms to optimize response times. - Add an additional host entry for the YDB service to the container configuration.
…mproved stability - Change action references in slo-report.yml and slo.yml to the new commit version for consistency.
polRk
force-pushed
the
update-slo-action
branch
from
6df1c21 to
0ad25cb
Compare
asmyasnikov
approved these changes
Nov 26, 2025
qrort
reviewed
Nov 26, 2025
kprokopenko
reviewed
Nov 26, 2025
| -write-timeout 100 \ | ||
| $EXTRA_ARGS" | ||
| echo "Starting ydb-app-current..." |
Collaborator
There was a problem hiding this comment.
Хорошо бы вынести в отдельный shell файл. Проще потом будет редактировать.
Member
Author
There was a problem hiding this comment.
Да, я думаю можно, но кода меньше не станет :) Только подсветка синтаксиса появится
kprokopenko
approved these changes
Nov 26, 2025
7 tasks
qrort
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information