fix: resolve deadlock in Endpoint.String() method #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summaryInferred base version: v3.118.3 |
kprokopenko
force-pushed
the
fix/endpoint-deadlock-1942
branch
from
7c3c28e to
f31158c
Compare
Fixes #1942 The String() method was acquiring a read lock and then calling Address() which tried to acquire another read lock. This could cause a deadlock when another goroutine called Touch() (which requires a write lock) between the two lock acquisitions. The fix inlines the address resolution logic in String() to avoid the nested lock acquisition.
kprokopenko
force-pushed
the
fix/endpoint-deadlock-1942
branch
from
f31158c to
7550045
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1944 +/- ##
==========================================
- Coverage 74.00% 72.62% -1.38%
==========================================
Files 392 392
Lines 34343 34345 +2
==========================================
- Hits 25414 24943 -471
- Misses 7810 8261 +451
- Partials 1119 1141 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gyborisov
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1942
Problem
The
String()method ininternal/endpoint/endpoint.gowas acquiring a read lock and then callingAddress()which tried to acquire another read lock. This could cause a deadlock when another goroutine calledTouch()(which requires a write lock) between the two lock acquisitions.Solution
The fix inlines the address resolution logic in
String()to avoid the nested lock acquisition. This ensures that only one read lock is acquired per call toString().Testing
Address()method but without the nested lockingReferences