-
Notifications
You must be signed in to change notification settings - Fork 105
feat: make schema operations limit exceeded error retryable #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make schema operations limit exceeded error retryable #1946
Conversation
This change makes the error 'Request exceeded a limit on the number of schema operations, try again later' retryable. The error is detected by checking the error message in the issues list and is treated as a retryable error with slow backoff (similar to OVERLOADED errors). Fixes #1933
github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptionscompatible changesAlterConsumerResetAvailabilityPeriod: added github.com/ydb-platform/ydb-go-sdk/v3/topic/topictypescompatible changesConsumer.AvailabilityPeriod: added summaryInferred base version: v3.118.3 |
74c0cb4 to
f5a3163
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1946 +/- ##
==========================================
+ Coverage 73.84% 73.85% +0.01%
==========================================
Files 392 392
Lines 34379 34391 +12
==========================================
+ Hits 25386 25401 +15
+ Misses 7862 7859 -3
Partials 1131 1131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR makes the error 'Request exceeded a limit on the number of schema operations, try again later' retryable.
Changes
hasSchemaOperationsLimitExceeded()to check for the specific error messageType()method to returnTypeRetryablefor GENERIC_ERROR with schema operations limit messageBackoffType()method to returnTypeSlowbackoff for this error (similar to OVERLOADED errors)Testing
All existing tests pass, and new tests have been added to verify:
Fixes #1933