Skip to content

promlinter enabled #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2023
Merged

promlinter enabled #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
014849a
promlinter enabled
asmyasnikov Dec 31, 2023
ce8c48e
fix issues
asmyasnikov Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ linters:
- nonamedreturns
- nosnakecase
- paralleltest
- promlinter
- protogetter
- scopelint
- structcheck
Expand Down
3 changes: 3 additions & 0 deletions examples/serverless/url_shortener/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,15 @@ func getService(ctx context.Context, dsn string, opts ...ydb.Option) (s *service
calls = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Namespace: "app",
Name: "calls",
Help: "application calls counter",
}, []string{
"method",
"success",
})
callsLatency = prometheus.NewHistogramVec(prometheus.HistogramOpts{
Namespace: "app",
Name: "latency",
Help: "application calls latencies",
Buckets: []float64{
(1 * time.Millisecond).Seconds(),
(5 * time.Millisecond).Seconds(),
Expand All @@ -114,6 +116,7 @@ func getService(ctx context.Context, dsn string, opts ...ydb.Option) (s *service
callsErrors = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Namespace: "app",
Name: "errors",
Help: "application errors counter",
}, []string{
"method",
})
Expand Down