Skip to content

Fix invalid read_from usage #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
+6 −12
Merged

Fix invalid read_from usage #717

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74de0d7
Update ydb_topic.py
victimsnino Nov 10, 2025
4f0d206
Update ydb_topic.py
victimsnino Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions ydb/_grpc/grpcwrapper/ydb_topic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,18 +479,12 @@ class TopicReadSettings(IToProto):
def to_proto(
self,
) -> ydb_topic_pb2.StreamReadMessage.InitRequest.TopicReadSettings:
res = ydb_topic_pb2.StreamReadMessage.InitRequest.TopicReadSettings()
res.path = self.path
res.partition_ids.extend(self.partition_ids)
max_lag = proto_duration_from_timedelta(self.max_lag)
if max_lag is not None:
res.max_lag = max_lag

read_from = proto_timestamp_from_datetime(self.read_from)
if read_from is not None:
res.read_from = read_from

return res
return ydb_topic_pb2.StreamReadMessage.InitRequest.TopicReadSettings(
path=self.path,
partition_ids=self.partition_ids,
max_lag=proto_duration_from_timedelta(self.max_lag),
read_from=proto_timestamp_from_datetime(self.read_from),
)

@dataclass
class InitResponse(IFromProto):
Expand Down
Loading