Skip to content

Conversation

yurikiselev
Copy link
Collaborator

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Правки в новые схемные секреты, которые отключены по дефолту флагом EnableSchemaSecrets. В 25-3 они уже заехали: поддержаны схемные объекты для секретов, SQL-синтаксис работы с ними, использование в федеративных запросах, которым нужен один секрет, и пр.
Тут доливаются доработки, чтобы секреты могли использоваться в запросах с несколькими секретами и разные доработки в новом локальном сервисе секретов, который отключен по дефолту.

@yurikiselev yurikiselev self-assigned this Oct 2, 2025
Copy link

github-actions bot commented Oct 2, 2025

🟢 2025-10-02 11:58:58 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Oct 2, 2025

2025-10-02 11:59:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for cb515c1 has started.
2025-10-02 11:59:36 UTC Artifacts will be uploaded here
2025-10-02 12:04:05 UTC ya make is running...
🟡 2025-10-02 13:55:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40157 37463 0 2 2665 27

2025-10-02 13:58:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-02 14:11:48 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
695 (only retried tests) 679 0 0 1 15

🟢 2025-10-02 14:11:58 UTC Build successful.
🟢 2025-10-02 14:12:14 UTC ydbd size 2.3 GiB changed* by +63.3 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: badfcf5 merge: cb515c1 diff diff %
ydbd size 2 431 218 312 Bytes 2 431 283 152 Bytes +63.3 KiB +0.003%
ydbd stripped size 520 843 304 Bytes 520 855 976 Bytes +12.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 2, 2025

2025-10-02 12:00:15 UTC Pre-commit check linux-x86_64-release-asan for cb515c1 has started.
2025-10-02 12:00:29 UTC Artifacts will be uploaded here
2025-10-02 12:04:22 UTC ya make is running...
🟡 2025-10-02 14:39:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17487 17030 0 161 264 32

🟢 2025-10-02 14:40:39 UTC Build successful.
🟡 2025-10-02 14:41:03 UTC ydbd size 3.8 GiB changed* by +104.0 KiB, which is >= 100.0 KiB vs stable-25-3: Warning

ydbd size dash stable-25-3: badfcf5 merge: cb515c1 diff diff %
ydbd size 4 045 053 968 Bytes 4 045 160 416 Bytes +104.0 KiB +0.003%
ydbd stripped size 1 506 926 656 Bytes 1 506 960 224 Bytes +32.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yurikiselev yurikiselev linked an issue Oct 2, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Oct 3, 2025

2025-10-03 08:55:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for b4fd89a has started.
2025-10-03 08:55:34 UTC Artifacts will be uploaded here
2025-10-03 08:59:27 UTC ya make is running...
🟡 2025-10-03 10:28:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40160 37487 0 1 2650 22

2025-10-03 10:32:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-03 10:47:58 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
330 (only retried tests) 313 0 0 1 16

🟢 2025-10-03 10:48:07 UTC Build successful.
🟢 2025-10-03 10:48:24 UTC ydbd size 2.3 GiB changed* by +66.8 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: e9cdc65 merge: b4fd89a diff diff %
ydbd size 2 431 247 856 Bytes 2 431 316 272 Bytes +66.8 KiB +0.003%
ydbd stripped size 520 845 928 Bytes 520 862 632 Bytes +16.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2025

2025-10-03 08:56:24 UTC Pre-commit check linux-x86_64-release-asan for b4fd89a has started.
2025-10-03 08:56:40 UTC Artifacts will be uploaded here
2025-10-03 09:00:49 UTC ya make is running...
🟡 2025-10-03 11:21:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17489 16963 0 182 318 26

🟢 2025-10-03 11:23:17 UTC Build successful.
🟢 2025-10-03 11:23:43 UTC ydbd size 3.8 GiB changed* by +99.3 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: e9cdc65 merge: b4fd89a diff diff %
ydbd size 4 045 108 856 Bytes 4 045 210 512 Bytes +99.3 KiB +0.003%
ydbd stripped size 1 506 940 992 Bytes 1 506 970 336 Bytes +28.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yurikiselev yurikiselev force-pushed the gh-26137-merge-secrets-fixes-to-stable-25-3 branch from 7d23d5a to 565d09b Compare October 8, 2025 12:53
Copy link

github-actions bot commented Oct 8, 2025

2025-10-08 12:55:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for bb9fb6c has started.
2025-10-08 12:56:05 UTC Artifacts will be uploaded here
2025-10-08 13:00:53 UTC ya make is running...
🟢 2025-10-08 15:04:34 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40187 37514 0 0 2650 23

🟢 2025-10-08 15:08:12 UTC Build successful.
🟢 2025-10-08 15:08:26 UTC ydbd size 2.3 GiB changed* by +64.6 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: 9596710 merge: bb9fb6c diff diff %
ydbd size 2 431 923 336 Bytes 2 431 989 440 Bytes +64.6 KiB +0.003%
ydbd stripped size 520 956 264 Bytes 520 972 520 Bytes +15.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 8, 2025

2025-10-08 12:57:55 UTC Pre-commit check linux-x86_64-release-asan for bb9fb6c has started.
2025-10-08 12:58:09 UTC Artifacts will be uploaded here
2025-10-08 13:02:11 UTC ya make is running...
🟡 2025-10-08 15:44:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17515 17078 0 142 275 20

🟢 2025-10-08 15:45:40 UTC Build successful.
🟡 2025-10-08 15:46:03 UTC ydbd size 3.8 GiB changed* by +106.6 KiB, which is >= 100.0 KiB vs stable-25-3: Warning

ydbd size dash stable-25-3: 9596710 merge: bb9fb6c diff diff %
ydbd size 4 046 244 848 Bytes 4 046 354 056 Bytes +106.6 KiB +0.003%
ydbd stripped size 1 507 294 720 Bytes 1 507 332 256 Bytes +36.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yurikiselev yurikiselev marked this pull request as ready for review October 9, 2025 03:55
@yurikiselev yurikiselev requested a review from a team as a code owner October 9, 2025 03:55
@yurikiselev yurikiselev enabled auto-merge October 9, 2025 11:30
Copy link

github-actions bot commented Oct 10, 2025

2025-10-10 11:00:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6f001bb has started.
2025-10-10 11:01:01 UTC Artifacts will be uploaded here
2025-10-10 11:04:58 UTC ya make is running...
🟡 2025-10-10 13:10:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40190 37506 0 7 2651 26

2025-10-10 13:14:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-10 13:41:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
606 (only retried tests) 581 0 2 2 21

2025-10-10 13:41:21 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-10 13:59:58 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
564 (only retried tests) 545 0 0 1 18

🟢 2025-10-10 14:00:08 UTC Build successful.
🟡 2025-10-10 14:00:27 UTC ydbd size 2.3 GiB changed* by +106.4 KiB, which is >= 100.0 KiB vs stable-25-3: Warning

ydbd size dash stable-25-3: 1338380 merge: 6f001bb diff diff %
ydbd size 2 431 939 720 Bytes 2 432 048 672 Bytes +106.4 KiB +0.004%
ydbd stripped size 520 962 280 Bytes 520 979 624 Bytes +16.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 10, 2025

2025-10-10 11:01:05 UTC Pre-commit check linux-x86_64-release-asan for 6f001bb has started.
2025-10-10 11:01:19 UTC Artifacts will be uploaded here
2025-10-10 11:05:30 UTC ya make is running...
🟡 2025-10-10 14:11:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17517 16948 0 237 308 24

🟢 2025-10-10 14:12:47 UTC Build successful.
🟡 2025-10-10 14:13:14 UTC ydbd size 3.8 GiB changed* by +176.6 KiB, which is >= 100.0 KiB vs stable-25-3: Warning

ydbd size dash stable-25-3: 1338380 merge: 6f001bb diff diff %
ydbd size 4 046 266 960 Bytes 4 046 447 840 Bytes +176.6 KiB +0.004%
ydbd stripped size 1 507 304 448 Bytes 1 507 363 520 Bytes +57.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yurikiselev yurikiselev merged commit 2abdd14 into ydb-platform:stable-25-3 Oct 13, 2025
12 checks passed
@yurikiselev yurikiselev deleted the gh-26137-merge-secrets-fixes-to-stable-25-3 branch October 13, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge secrets fixes to stable-25-3 and stable-25-3-1

2 participants