Skip to content

Conversation

@vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Oct 15, 2025

Changelog entry

added state storage status to healthcheck api

Changelog category

  • New feature

Description for reviewers

  • Пока только сам state storage - наверное нужно отдельно board, schemboard так же?
  • Неявно используется предположение, что >1 ring group бывает только в бриджмоде - поскольку код в CMS явно на это полагается. А это точно правда?)
  • Проблемы в несинхронизированной ринг-группе не зажигаются. В CMS кажется состояние ринг-группы не учитывается, хорошо ли это?

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

🟢 2025-10-15 13:34:17 UTC The validation of the Pull Request description is successful.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@vporyadke vporyadke linked an issue Oct 15, 2025 that may be closed by this pull request
@vporyadke vporyadke marked this pull request as ready for review October 15, 2025 13:30
@vporyadke vporyadke requested a review from a team as a code owner October 15, 2025 13:30
@vporyadke vporyadke requested review from CyberROFL and stanislav-shchetinin and removed request for stanislav-shchetinin October 15, 2025 13:30
@CyberROFL
Copy link
Member

Пока только сам state storage - наверное нужно отдельно board, schemboard так же?

Да.

Неявно используется предположение, что >1 ring group бывает только в бриджмоде - поскольку код в CMS явно на это полагается. А это точно правда?)

@Evgenik2 меня поправит, но такое предположение неверное. Более одной группы колец может быть и не в bridge mode.

Проблемы в несинхронизированной ринг-группе не зажигаются. В CMS кажется состояние ринг-группы не учитывается, хорошо ли это?

Тут не очень понял вопрос. @pixcc @stanislav-shchetinin fyi.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@stanislav-shchetinin
Copy link
Collaborator

stanislav-shchetinin commented Oct 20, 2025

Пока только сам state storage - наверное нужно отдельно board, schemboard так же?

Да.

Неявно используется предположение, что >1 ring group бывает только в бриджмоде - поскольку код в CMS явно на это полагается. А это точно правда?)

@Evgenik2 меня поправит, но такое предположение неверное. Более одной группы колец может быть и не в bridge mode.

Проблемы в несинхронизированной ринг-группе не зажигаются. В CMS кажется состояние ринг-группы не учитывается, хорошо ли это?

Тут не очень понял вопрос. @pixcc @stanislav-shchetinin fyi.

Возможно, речь идет про это, но тут изначально учитываются кольца только из нулевой ring group.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

2025-10-20 16:14:24 UTC Pre-commit check linux-x86_64-release-asan for 942118a has started.
2025-10-20 16:15:20 UTC Artifacts will be uploaded here
2025-10-20 16:20:12 UTC ya make is running...
🟡 2025-10-20 18:37:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18675 18130 0 252 274 19

🟢 2025-10-20 18:38:10 UTC Build successful.
🟡 2025-10-20 18:38:35 UTC ydbd size 3.8 GiB changed* by +295.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 51a3ffe merge: 942118a diff diff %
ydbd size 4 037 699 720 Bytes 4 038 001 848 Bytes +295.0 KiB +0.007%
ydbd stripped size 1 500 299 872 Bytes 1 500 403 904 Bytes +101.6 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

2025-10-20 16:17:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 942118a has started.
2025-10-20 16:17:17 UTC Artifacts will be uploaded here
2025-10-20 16:21:38 UTC ya make is running...
🟡 2025-10-20 18:13:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41946 39145 0 8 2764 29

2025-10-20 18:13:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-20 18:39:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
612 (only retried tests) 585 0 1 6 20

2025-10-20 18:39:38 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-20 18:55:40 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
584 (only retried tests) 565 0 0 0 19

🟢 2025-10-20 18:55:43 UTC Build successful.
🟡 2025-10-20 18:56:02 UTC ydbd size 2.3 GiB changed* by +169.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: dc457de merge: 942118a diff diff %
ydbd size 2 426 466 936 Bytes 2 426 640 832 Bytes +169.8 KiB +0.007%
ydbd stripped size 516 379 688 Bytes 516 409 064 Bytes +28.7 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke merged commit 51b6652 into ydb-platform:main Oct 20, 2025
12 checks passed
ydbot pushed a commit that referenced this pull request Oct 23, 2025
ydbot pushed a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HealthCheck: check StateStorage/Board/SchemeBoard health

3 participants