support renames for dq joins #26897
support renames for dq joins #26897
Conversation
|
🟢 |
|
⚪ |
|
⚪ |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
nfrmtk
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
nfrmtk
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| auto returnType = NCommon::BuildType(*node.GetTypeAnn(), ctx.PgmBuilder(), errorStream); | ||
| YQL_ENSURE(returnType, "Failed to build return type: " << errorStream.Str()); | ||
|
|
||
| auto graceJoinRenames = [&]{ |
There was a problem hiding this comment.
I suggest not calling the format with two arrays “gracejoin.” Let’s just call it “the format with two arrays,” since “gracejoin” causes confusion. It’s not urgent for this PR.
| return td; | ||
| } | ||
|
|
||
| void Test(TJoinTestData testData, bool blockJoin) { |
There was a problem hiding this comment.
Please add an assert inside the join to ensure these types are not used. It’s not urgent for this PR.
2 participants
closes: #25784
closes: #26780
...
Changelog category
Description for reviewers
todo: check if benchmarks work, and try to add data validation to ydb/core/kqp/ut/join/kqp_block_hash_join_ut.cpp
...