Skip to content

25-1-4: schemeshard stats processing opt 0 #27482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

25-1-4: schemeshard stats processing opt 0 #27482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions ydb/core/tx/schemeshard/schemeshard__table_stats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,18 +475,32 @@ bool TTxStoreTableStats::PersistSingleStats(const TPathId& pathId,
return true;
}

auto path = TPath::Init(pathId, Self);
auto checks = path.Check();
constexpr ui64 deltaShards = 2;
checks
.PathShardsLimit(deltaShards)
.ShardsLimit(deltaShards);
if (!checks) {
LOG_NOTICE_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"Do not request full stats from datashard"
<< ", datashard: " << datashardId
<< ", reason: " << checks.GetError());
return true;
//NOTE: intentionally avoid using TPath.Check().{PathShardsLimit,ShardsLimit}() here.
// PathShardsLimit() performs pedantic validation by recalculating shard count through
// iteration over entire ShardInfos, which is too slow for this hot spot. It also performs
// additional lookups we want to avoid.
{
constexpr ui64 deltaShards = 2;
if ((pathElement->GetShardsInside() + deltaShards) > subDomainInfo->GetSchemeLimits().MaxShardsInPath) {
LOG_NOTICE_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD, "Do not request full stats from datashard " << datashardId
<< ", reason: shards count limit exceeded (in path)"
<< ", limit: " << subDomainInfo->GetSchemeLimits().MaxShardsInPath
<< ", current: " << pathElement->GetShardsInside()
<< ", delta: " << deltaShards
);
return true;
}
const auto currentShards = (subDomainInfo->GetShardsInside() - subDomainInfo->GetBackupShards());
if ((currentShards + deltaShards) > subDomainInfo->GetSchemeLimits().MaxShards) {
LOG_NOTICE_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD, "Do not request full stats from datashard " << datashardId
<< ", datashard: " << datashardId
<< ", reason: shards count limit exceeded (in subdomain)"
<< ", limit: " << subDomainInfo->GetSchemeLimits().MaxShards
<< ", current: " << currentShards
<< ", delta: " << deltaShards
);
return true;
}
}

if (newStats.HasBorrowedData) {
Expand All @@ -496,9 +510,11 @@ bool TTxStoreTableStats::PersistSingleStats(const TPathId& pathId,
return true;
}

if (path.IsLocked()) {
// path.IsLocked() and path.LockedBy() equivalent
if (const auto& found = Self->LockedPaths.find(pathId); found != Self->LockedPaths.end()) {
const auto txId = found->second;
LOG_DEBUG_S(ctx, NKikimrServices::FLAT_TX_SCHEMESHARD,
"Postpone split tablet " << datashardId << " because it is locked by " << path.LockedBy());
"Postpone split tablet " << datashardId << " because it is locked by " << txId);
return true;
}

Expand Down
Loading