-
Notifications
You must be signed in to change notification settings - Fork 732
fix stuck reassign actor #28195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix stuck reassign actor #28195
Conversation
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the TReassignTabletWaitActor class to prevent premature completion and improve code organization. The key change is moving from a pre-calculated total count to an incremental approach where tablets are added individually, and completion is checked dynamically.
- Initializes
TabletsTotalto 0 instead ofmax()to avoid overflow issues - Introduces
AddTablet()method to encapsulate the registration logic and increment the counter - Adds
CheckCompletion()method to centralize completion checking logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
Можно ли добавить тест? |
Changelog entry
fix an issue where autobalancing could stop after manual group reassign #28194
Changelog category
Description for reviewers
Пару раз (странно, что не постоянно) наблюдали, что после реассайна остаются висящие акторы, а пока висят акторы мы не запускаем балансер. Чиню зависание если запрос пришёл на реассайн несуществующей таблетки - а это вполне реальный кейс, потому что она могла удалиться с тех пор, как мы сделали query.