Encryption settings in API for backups to fs #28305
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
🟢 |
There was a problem hiding this comment.
Pull Request Overview
This PR extends the file system import/export functionality in the YDB API to support encryption and more flexible path handling, bringing it to feature parity with the S3 import/export capabilities.
Key changes:
- Added encryption support for FS import/export operations with
encryption_settingsfield - Made
source_pathanddestination_pathfields optional in Item messages to support automatic path resolution - Added global
source_pathanddestination_pathfields for more flexible path configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ydb/public/api/protos/ydb_import.proto | Added encryption support, made Item fields optional, and added global destination_path for FS imports |
| ydb/public/api/protos/ydb_export.proto | Added encryption support, made Item.destination_path optional, and added global source_path for FS exports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Заметил вот тут отличие от других методов этого сервиса: https://github.com/stanislav-shchetinin/ydb/blob/7c83b4ae4e1e1870b050fe49ca057fbc1427d06c/ydb/public/api/grpc/ydb_export_v1.proto#L20 |
UgnineSirdis
left a comment
UgnineSirdis
left a comment
There was a problem hiding this comment.
А нам актуален параметр number_of_retries тут?
UgnineSirdis
left a comment
UgnineSirdis
left a comment
There was a problem hiding this comment.
Касательно EncryptionSettings вроде всё просто. Но эти настройки по требованиям идут рука об руку с идеей о том, что экспорт должен представлять собой нечто целое. Я бы подумал, не объявить ли это основным подходом. В таком случае некоторые из "путевых" параметров можно никак не добавлять в API
Мы хотим через этот вызов делать экспорт в том числе и в NFS, а там при мягком монтировании нужно указать количество ретраев. @UgnineSirdis |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
stanislav-shchetinin
dismissed stale reviews from CyberROFL and UgnineSirdis
via
67c33c9
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
stanislav-shchetinin
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
3 participants
Changelog entry
...
Changelog category
Description for reviewers
...