Mlp tests #28411
Mlp tests #28411
Conversation
|
🟢 |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test utilities for snapshot/WAL testing and adds new test cases for SlowZone retention behavior. It also fixes a missing DLQ message count increment and adds a new method to retrieve locked message groups.
- Introduces
Begin(),End(), andAssertLoad()helper methods to reduce test code duplication - Adds three new test cases to verify SlowZone retention behavior with different message counts
- Fixes DLQ message count metric initialization in snapshot loading
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mlp_storage_ut.cpp | Refactors test utilities with Begin/End/AssertLoad pattern, updates existing tests to use the new pattern, adds retention period change and new SlowZone retention tests |
| mlp_storage__serialization.cpp | Adds missing DLQ message count increment during snapshot initialization |
| mlp_storage.h | Declares new GetLockedMessageGroupsId() method for test assertions |
| mlp_storage.cpp | Implements GetLockedMessageGroupsId() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
2 participants
Changelog entry
...
Changelog category
Description for reviewers
...