Skip to content

Correct distconf quorum for scenario when user adds new nodes to cluster #28455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

Correct distconf quorum for scenario when user adds new nodes to cluster #28455

merged 1 commit into from
Nov 12, 2025

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Nov 10, 2025

Changelog entry

Correct distconf quorum for scenario when user adds new nodes to cluster

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This patch corrects adding new nodes scenario. Now distconf connects to these nodes and writes config to them before making quorum decision.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 08:36:39 UTC Pre-commit check linux-x86_64-release-asan for a8edce5 has started.
⚪ 2025-11-10 08:36:55 UTC Artifacts will be uploaded here
⚪ 2025-11-10 08:39:09 UTC ya make is running...
🔴 2025-11-10 09:08:47 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 08:36:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for a8edce5 has started.
⚪ 2025-11-10 08:36:55 UTC Artifacts will be uploaded here
⚪ 2025-11-10 08:39:13 UTC ya make is running...
🔴 2025-11-10 09:05:13 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

🟢 2025-11-10 08:37:10 UTC The validation of the Pull Request description is successful.

@alexvru alexvru force-pushed the distconf/correct-quorum-when-adding-nodes branch from 5c2d6d6 to 819e588 Compare November 10, 2025 15:12
@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 15:13:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 74f698c has started.
⚪ 2025-11-10 15:14:04 UTC Artifacts will be uploaded here
⚪ 2025-11-10 15:16:26 UTC ya make is running...
🔴 2025-11-10 15:42:05 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 15:14:08 UTC Pre-commit check linux-x86_64-release-asan for 74f698c has started.
⚪ 2025-11-10 15:14:27 UTC Artifacts will be uploaded here
⚪ 2025-11-10 15:16:48 UTC ya make is running...
🔴 2025-11-10 15:45:03 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the distconf/correct-quorum-when-adding-nodes branch from 819e588 to aeb93dd Compare November 11, 2025 07:09
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 07:11:35 UTC Pre-commit check linux-x86_64-release-asan for 39bd71d has started.
⚪ 2025-11-11 07:11:52 UTC Artifacts will be uploaded here
⚪ 2025-11-11 07:14:11 UTC ya make is running...
🔴 2025-11-11 07:47:32 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 07:12:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 39bd71d has started.
⚪ 2025-11-11 07:12:51 UTC Artifacts will be uploaded here
⚪ 2025-11-11 07:15:08 UTC ya make is running...
🔴 2025-11-11 07:45:59 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the distconf/correct-quorum-when-adding-nodes branch from aeb93dd to 6115328 Compare November 11, 2025 08:05
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 08:07:14 UTC Pre-commit check linux-x86_64-release-asan for 1f802f9 has started.
⚪ 2025-11-11 08:07:32 UTC Artifacts will be uploaded here
⚪ 2025-11-11 08:09:47 UTC ya make is running...
🔴 2025-11-11 08:16:05 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 08:09:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1f802f9 has started.
⚪ 2025-11-11 08:09:35 UTC Artifacts will be uploaded here
⚪ 2025-11-11 08:11:53 UTC ya make is running...
🔴 2025-11-11 08:18:02 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the distconf/correct-quorum-when-adding-nodes branch from 6115328 to de24241 Compare November 11, 2025 09:25
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 09:28:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8409fe4 has started.
⚪ 2025-11-11 09:29:08 UTC Artifacts will be uploaded here
⚪ 2025-11-11 09:31:15 UTC ya make is running...
⚫ 2025-11-11 09:36:16 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 09:29:15 UTC Pre-commit check linux-x86_64-release-asan for 8409fe4 has started.
⚪ 2025-11-11 09:29:33 UTC Artifacts will be uploaded here
⚪ 2025-11-11 09:31:42 UTC ya make is running...
⚫ 2025-11-11 09:36:15 UTC Check cancelled

@alexvru alexvru force-pushed the distconf/correct-quorum-when-adding-nodes branch from de24241 to 4284068 Compare November 11, 2025 09:35
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 09:38:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for b9bbac6 has started.
⚪ 2025-11-11 09:39:22 UTC Artifacts will be uploaded here
⚪ 2025-11-11 09:41:30 UTC ya make is running...
🔴 2025-11-11 10:20:12 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 09:40:01 UTC Pre-commit check linux-x86_64-release-asan for b9bbac6 has started.
⚪ 2025-11-11 09:40:18 UTC Artifacts will be uploaded here
⚪ 2025-11-11 09:42:23 UTC ya make is running...
🔴 2025-11-11 10:16:23 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the distconf/correct-quorum-when-adding-nodes branch from 4284068 to 325974d Compare November 11, 2025 13:12
@alexvru alexvru requested a review from a team as a code owner November 11, 2025 13:12
@alexvru alexvru requested a review from vporyadke November 11, 2025 13:12
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 13:14:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7fbbccd has started.
⚪ 2025-11-11 13:14:24 UTC Artifacts will be uploaded here
⚪ 2025-11-11 13:16:32 UTC ya make is running...
🔴 2025-11-11 13:55:08 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 13:16:58 UTC Pre-commit check linux-x86_64-release-asan for 7fbbccd has started.
⚪ 2025-11-11 13:17:15 UTC Artifacts will be uploaded here
⚪ 2025-11-11 13:19:25 UTC ya make is running...
🔴 2025-11-11 13:57:30 UTC Build failed, see the logs. Also see fail summary
🟡 2025-11-11 13:57:49 UTC ydbd size 3.8 GiB changed* by +265.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 531f527 merge: 7fbbccd diff diff %
ydbd size 4 081 237 048 Bytes 4 081 508 848 Bytes +265.4 KiB +0.007%
ydbd stripped size 1 515 018 120 Bytes 1 515 081 352 Bytes +61.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the distconf/correct-quorum-when-adding-nodes branch from 325974d to f5d3e12 Compare November 11, 2025 14:47
@alexvru alexvru force-pushed the distconf/correct-quorum-when-adding-nodes branch from f5d3e12 to 5a4e086 Compare November 11, 2025 14:48
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 14:48:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 828bf33 has started.
⚪ 2025-11-11 14:48:41 UTC Artifacts will be uploaded here
⚪ 2025-11-11 14:50:18 UTC ya make is running...
🟡 2025-11-11 17:06:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41727 38903 0 2 2791 31

⚪ 2025-11-11 17:07:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-11 17:16:45 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 45 0 0 0 14

🟢 2025-11-11 17:16:52 UTC Build successful.
🟡 2025-11-11 17:17:13 UTC ydbd size 2.3 GiB changed* by +197.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8a4d64c merge: 828bf33 diff diff %
ydbd size 2 437 870 264 Bytes 2 438 072 088 Bytes +197.1 KiB +0.008%
ydbd stripped size 518 656 528 Bytes 518 676 176 Bytes +19.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 14:49:04 UTC Pre-commit check linux-x86_64-release-asan for 828bf33 has started.
⚪ 2025-11-11 14:51:12 UTC Artifacts will be uploaded here
⚪ 2025-11-11 14:53:14 UTC ya make is running...
🟡 2025-11-11 17:29:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18226 17815 0 139 243 29

🟢 2025-11-11 17:29:42 UTC Build successful.
🟡 2025-11-11 17:30:09 UTC ydbd size 3.8 GiB changed* by +265.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8a4d64c merge: 828bf33 diff diff %
ydbd size 4 081 237 432 Bytes 4 081 509 216 Bytes +265.4 KiB +0.007%
ydbd stripped size 1 515 018 312 Bytes 1 515 081 544 Bytes +61.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) November 11, 2025 17:52
mregrock
mregrock approved these changes Nov 11, 2025
View reviewed changes
Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexvru alexvru merged commit a56d656 into ydb-platform:main Nov 12, 2025
11 checks passed
@alexvru alexvru deleted the distconf/correct-quorum-when-adding-nodes branch November 12, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stanislav-shchetinin stanislav-shchetinin stanislav-shchetinin approved these changes

@mregrock mregrock mregrock approved these changes

@vporyadke vporyadke Awaiting requested review from vporyadke vporyadke is a code owner automatically assigned from ydb-platform/core

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexvru @stanislav-shchetinin @mregrock