Skip to content

Fix LastOffset bug in PQ #28667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

Fix LastOffset bug in PQ #28667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa44eb
Fix LastOffset bug in PQ
FloatingCrowbar Nov 11, 2025
8c23658
Fix test's canonical
FloatingCrowbar Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ydb/core/persqueue/pqtablet/partition/partition_read.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,10 @@ TMaybe<TReadAnswer> TReadInfo::AddBlobsFromBody(const TVector<NPQ::TRequestedBlo
if (res.IsLastPart()) {
PartNo = 0;
++Offset;
if (LastOffset && Offset >= LastOffset) {
needStop = true;
break;
}
} else {
++PartNo;
}
Expand Down Expand Up @@ -640,6 +644,9 @@ TReadAnswer TReadInfo::FormAnswer(
if (updateUsage(writeBlob)) {
break;
}
if (LastOffset && Offset >= LastOffset) {
break;
}
}
}

Expand Down
2 changes: 2 additions & 0 deletions ydb/core/persqueue/ut/counters_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,11 +815,13 @@ Y_UNIT_TEST(PartitionKeyCompaction) {
group->GetNamedCounter("name", "topic.partition.write.lag_milliseconds_max", false)->Set(600);
group->GetNamedCounter("name", "topic.partition.uptime_milliseconds_min", false)->Set(30000);
group->GetNamedCounter("name", "topic.partition.write.lag_milliseconds_max", false)->Set(600);
group->GetNamedCounter("name", "topic.partition.read.throttled_microseconds_max", false)->Set(2000);
group = group->GetSubgroup("consumer", "__ydb_compaction_consumer");
group->GetNamedCounter("name", "topic.partition.write.lag_milliseconds_max", false)->Set(200);
group->GetNamedCounter("name", "topic.partition.end_to_end_lag_milliseconds_max", false)->Set(30000);
group->GetNamedCounter("name", "topic.partition.read.throttled_microseconds_max", false)->Set(2000);
group->GetNamedCounter("name", "topic.partition.read.idle_milliseconds_max", false)->Set(300);
group->GetNamedCounter("name", "topic.partition.read.lag_milliseconds_max", false)->Set(300);

TStringStream countersStr;
dbGroup->OutputHtml(countersStr);
Expand Down
8 changes: 4 additions & 4 deletions ydb/core/persqueue/ut/resources/counters_topics_extended.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
name=topic.partition.producers_count_max: 1
name=topic.partition.read.inflight_throttled_microseconds_max: 0
name=topic.partition.read.speed_limit_bytes_per_second: 20000000000
name=topic.partition.read.throttled_microseconds_max: 148
name=topic.partition.read.throttled_microseconds_max: 2000
name=topic.partition.read_without_consumer.speed_limit_bytes_per_second: 0
name=topic.partition.read_without_consumer.throttled_microseconds_max: 0
name=topic.partition.storage_bytes_max: 7549747200
Expand All @@ -53,12 +53,12 @@
name=topic.partition.committed_read_lag_milliseconds_max: 0
name=topic.partition.end_to_end_lag_milliseconds_max: 30000
name=topic.partition.read.idle_milliseconds_max: 300
name=topic.partition.read.lag_messages_max: 0
name=topic.partition.read.lag_milliseconds_max: 0
name=topic.partition.read.lag_messages_max: 1
name=topic.partition.read.lag_milliseconds_max: 300
name=topic.partition.read.speed_limit_bytes_per_second: 4194304
name=topic.partition.read.throttled_microseconds_max: 2000
name=topic.partition.write.lag_milliseconds_max: 200
name=topic.read.lag_messages: 0
name=topic.read.lag_messages: 1

consumer=client:
name=topic.partition.alive_count: 0
Expand Down
Loading